gh-143750: Compile OpenSSL with TSan for TSan CI #143752
Conversation
- Also fix "Install dependencies" step so that we use the installed Clang. We can use clang-20 on both ASan and TSan now.
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-24.04] | ||
| openssl_ver: [3.5.4] | ||
| runs-on: ${{ matrix.os }} |
There was a problem hiding this comment.
Plz move these to inputs: and host the matrix on the calling side (in build.yml). This is the separation I was going for when I first introduced the reusable-*.yml module pattern — no matrices in modules.
There was a problem hiding this comment.
This is a convenient way to define a variable that's reused a few times in the workflow. It could be an env, but it's not actually needed in the environment.
| && ' (free-threading)' | ||
| || '' | ||
| }} |
There was a problem hiding this comment.
This will also need to interpolate new matrix factors since the job names will be confusing if there's ever more than one job.
There was a problem hiding this comment.
There's the same jobs as before. The TSan ones just now compile OpenSSL with TSan
| run: | | ||
| if [ "${SANITIZER}" = "TSan" ]; then |
There was a problem hiding this comment.
We can move this conditional to the GHA step so that skipping is more prominent.
| run: | | |
| if [ "${SANITIZER}" = "TSan" ]; then | |
| if: inputs.sanitizer == 'TSan' | |
| run: | |
Also drop fi and the second conditional block below too.
There was a problem hiding this comment.
I merged the if blocks, but you can't lift the conditional the GHA step because you still need the:
else
echo "UBSAN_OPTIONS=${SAN_LOG_OPTION}" >> "$GITHUB_ENV"
fi
and the unconditional
echo "CC=clang" >> "$GITHUB_ENV"
echo "CXX=clang++" >> "$GITHUB_ENV"
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
2 participants
Also fix "Install dependencies" step so that we use the installed Clang. We can use clang-20 on both TSan and UBSan now.